Repository navigation
refactor(compass-app): extract embedded launch pipeline into internal/embedded - #1777
Open
rigel-mintaka wants to merge 3 commits into
Open
rigel-mintaka wants to merge 3 commits into
rigel-mintaka wants to merge 3 commits into
Conversation
…/embedded Move the host-independent embedded pipeline (preflight, compass-stack up/down exec, WhoAmI over UDS, image and stack-binary resolution, the bring-up and teardown timeouts) from cmd/compass-app into a new go/internal/embedded package. Behaviour is unchanged; the app keeps runEmbedded, the quit controller, and the socket/mode resolvers. This gives the embedded launch a non-cgo package that an e2e test can drive without the Wails shell. Refs: RIG-4413 Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
❌ This pull request could not start testing because there was a merge conflict. See more details here.
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Compass engineering docs preview: https://compass-native-rig-4413-embe.compass-eng-docs.pages.dev Deployed from Changed pages: |
stackUpArgs has no caller outside the package. Comments that named the pre-move identifiers now name the current ones. Refs: RIG-4413 Co-authored-by: Matt Wilkinson <matt@rigel.build>
…mbedded The darwin gate requires named PASS lines for the machine and preflight tests, which now live in go/internal/embedded. Refs: RIG-4413 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
marked this pull request as ready for review
October 6, 2026 19:38
mattwilkinsonn
approved these changes
Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go/cmd/compass-appinto a new untagged package,go/internal/embedded. It covers preflight, thecompass-stack up/downexec, WhoAmI over the stack socket, image and stack-binary resolution, and the bring-up and teardown timeouts.runEmbedded, the quit controller, and the socket and mode resolvers. Behaviour is unchanged: function bodies and doc comments move as they are, and only identifiers are exported../internal/embedded/, where its named machine and preflight tests moved.stackUpArgsstays unexported because nothing outside the package calls it.Verification
go build ./...andgo vet ./...: pass.go vet -tags gtk4on both packages, plusGOOS=darwin go vet ./internal/embedded: pass.go test -race ./internal/embedded/...andgo test -race -tags gtk4 ./cmd/compass-app/...: pass.gtk4: 0 issues.Test*name from the old files exists in the new layout (commagainst main).rumdl check app-bundle/SMOKE.md: clean.Risks
None: this is a code move with no logic changes. Rollback is a revert.
Compatibility
No CLI, flag, or config change.
go/internal/embeddedis internal to the module.Documentation
app-bundle/SMOKE.mdnow cites the new symbol paths. Frozen design records are unchanged.Refs RIG-4413