Repository navigation
fix(design-ledger-gate): exempt Trunk merge-queue PRs from touch-coupling (RIG-4821) - #1922
Merged
mattwilkinsonn merged 2 commits intoOct 7, 2026
Merged
Conversation
…ling (RIG-4821) Trunk queue test PRs (`trunk-merge/*`) carry the Trunk banner as their body, so the `Ledger-impact:` scan always failed on queued PRs that touch a record. Each source PR already passed this leg on its own PR event. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
😎 This pull request was merged. |
… (RIG-4821) Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-comms-rig-4821-ledge.compass-eng-docs.pages.dev Deployed from Changed pages: |
rigel-mintaka
marked this pull request as ready for review
October 7, 2026 05:56
mattwilkinsonn
deleted the
compass-comms/rig-4821-ledger-gate-trunk-queue
branch
October 7, 2026 23:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #1799, the
design-ledger-gatetouch-coupling leg runs onpull_requestevents, including Trunk merge-queue test PRs (trunk-merge/*). Their body is the Trunk banner, so it never has aLedger-impact:line. Every queued PR that touches a design record failed in the queue (runs 37569555833, 37571057556).Change
trunk-merge/toEXEMPT_BRANCH_PREFIXESintools/design-ledger-gate/index.ts. It sits next torenovate/.pull_requestevent. The snapshot leg still runs on queue PRs.Record
docs/designs/repo/compass-shared-tools-repo/design.md: the Problem example and the T7 acceptance bullet no longer say compass lacks thetrunk-merge/exemption. No decision changes.Security note
renovate/. A PR namedtrunk-merge/...skips only the Ledger-impact coupling check. Snapshot and Status legs still run, and CODEOWNERS review is still required. Tightening both prefixes to the bot author is tracked in RIG-4823, along with one leftover record nit (the inventory table's drift cell).Tests
trunk-merge/ queue PR touching a record, no ledger, no decl → no violation. It failed before the fix and passes after.startsWith, not includescase still guards against a mid-branch match.bun test: 108 pass.tsc: clean. biome: no new findings. The gate passes on the tree: 378 rows, 158 records.Spec-impact: none
Ledger-impact: record-only fix (compass-shared-tools-repo Problem and T7 text match the code; no DL row change)
Refs RIG-4821
Co-authored-by: Matt Wilkinson matt@rigel.build