Repository navigation
Document implementation maturity in standards comparison - #253
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a6acb2a01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if row.get("artifact_type") in {"requirements_draft", "proposed_charter"}: | ||
| for dimension in required_dimensions - {"versioned_contract"}: | ||
| if dimensions[dimension].get("status") != "not_applicable": |
There was a problem hiding this comment.
Enforce the artifact-specific contract status
Require requirements_only for a requirements draft and charter_only for a proposed charter. This loop explicitly excludes versioned_contract, while the generic status allowlist accepts values such as verified, partial, and prototype; consequently, changing either row's contract status to any of those values still makes validate() return success and permits the exact requirements/charter misclassification this check is intended to prevent.
Useful? React with 👍 / 👎.
Scope
Local validation
Tracks #40 and preserves independent-implementation gate #31.