Skip to content

Update table classes for consistency - #364

Merged
Jeremy-Walton merged 2 commits into
mainfrom
consistent-naming
Oct 1, 2026
Merged

Jeremy-Walton merged 2 commits into
mainfrom
consistent-naming

Conversation

@Jeremy-Walton

@Jeremy-Walton Jeremy-Walton commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Why?

The Table class modifiers were not consistent in their naming with other optics classes. This adds more consistent names while retaining backwards compatibility.

What Changed

  • Update table density and layout names
  • Update docs to reflect
  • Retain old names for backwards compatibility

Quality Assurance

  • Have you tagged the PR with the correct labels?
  • Have you validated the changes?
    • Have you run linters? (yarn sanity-check)
    • Have you run prettier?
    • Have you tried building the css?
    • Have you tried building storybook?
  • Have you updated any usage of changed tokens?
  • [ ] Did you add a component?
    • [ ] Have you added it to the dependency graph?
    • [ ] Have you added it to the docs?
  • Did you update a component?
    • [ ] Have you updated the dependency graph?
    • Have you updated the docs?
  • Do you need to update the package version?
    • Did you update the example pages in .storybook/assets?
  • [ ] Were any changes made to the top level optics.css file?
    • [ ] Were those changes reflected in the other top level files?

@Jeremy-Walton Jeremy-Walton self-assigned this Oct 1, 2026
@Jeremy-Walton Jeremy-Walton added the Components Changes to a component label Oct 1, 2026

@dallasbpeters dallasbpeters left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the old classes be marked as deprecated? It would be nice if linters and other tools could pick up on the need to update the class.

@Jeremy-Walton

Copy link
Copy Markdown
Member Author

@dallasbpeters That would be nice but we don't have an Optics linter at the moment. I did make https://github.com/Jeremy-Walton/stylelint-bem and could totally see making something similar for Optics. We would just need to talk through what we want the rules to be.

@Jeremy-Walton
Jeremy-Walton merged commit 2352408 into main Oct 1, 2026
4 checks passed
@Jeremy-Walton
Jeremy-Walton deleted the consistent-naming branch October 1, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Components Changes to a component

Development

Successfully merging this pull request may close these issues.

4 participants