Update table classes for consistency - #364
Merged
Merged
Conversation
Jeremy-Walton
force-pushed
the
consistent-naming
branch
from
October 1, 2026 16:53
b35ed14 to
234cef1
Compare
zoopmaster
approved these changes
Oct 1, 2026
gavinomelia
approved these changes
Oct 1, 2026
dallasbpeters
left a comment
Member
There was a problem hiding this comment.
Should the old classes be marked as deprecated? It would be nice if linters and other tools could pick up on the need to update the class.
Member
Author
|
@dallasbpeters That would be nice but we don't have an Optics linter at the moment. I did make https://github.com/Jeremy-Walton/stylelint-bem and could totally see making something similar for Optics. We would just need to talk through what we want the rules to be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The Table class modifiers were not consistent in their naming with other optics classes. This adds more consistent names while retaining backwards compatibility.
What Changed
Quality Assurance
[ ] Did you add a component?[ ] Have you added it to the dependency graph?[ ] Have you added it to the docs?[ ] Have you updated the dependency graph?.storybook/assets?[ ] Were any changes made to the top level optics.css file?[ ] Were those changes reflected in the other top level files?