Repository navigation
[Fix] Discord Fast replies fail to attach selected images - #3205
Merged
mrubens merged 3 commits intoSep 24, 2026
Merged
Conversation
Contributor
Contributor
Author
| Resolved both Discord image-delivery findings in [0ad6b80](https://github.com/RooCodeInc/Roomote/commit/0ad6b809) and [65bbfde](https://github.com/RooCodeInc/Roomote/commit/65bbfde0). Fast now resolves selected image IDs against the current session, posts Discord embeds on direct and existing-session replies, and batches deferred-interaction overflow beyond ten images. Both review threads are resolved, and the latest Roomote code review check passes with no code issues. Focused API/SDK/Discord-provider tests, typechecks, pre-push checks, and CI passed. Proof handoff: blocked, `proof capture timed out`; no visual proof is included. |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 24, 2026 16:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
imageArtifactIdsas native Discord image embeds in direct Discord replies and replies on existing Fast sessions.Why this change was made
The Discord Fast adapter accepted a reply carrying selected image IDs but posted only its text, so Fast could claim a screenshot was attached when Discord received no image. Deferred Discord interactions also have a ten-embed per-message limit; larger selections must send additional batches rather than fail the whole reply.
Impact
Discord Fast replies now deliver selected task screenshots instead of silently dropping them, including retry replacement and deferred-interaction overflow paths. The fix does not overlap #3201's artifact-upload notification changes. Focused automated tests cover the Discord payload and session-scoped artifact resolution; visual proof capture timed out, so no screenshots are included.