Skip to content

[Fix] Discord Fast replies fail to attach selected images - #3205

Merged
mrubens merged 3 commits into
developfrom
feature/fast-image-reply-guidance-18p90poobl72m
Sep 24, 2026
Merged

mrubens merged 3 commits into
developfrom
feature/fast-image-reply-guidance-18p90poobl72m

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

​Opened on behalf of @mrubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Fast sends selected imageArtifactIds as native Discord image embeds in direct Discord replies and replies on existing Fast sessions.
  • Resolve selected images through the current Fast session before delivery. Deferred interaction replies edit the first ten embeds and post any remaining image batches; retry replacements also preserve embeds or repost through the image-capable path when they exceed edit limits.
  • Added focused regressions for artifact resolution and delivery, deferred interactions, and retry replacements.

Why this change was made

The Discord Fast adapter accepted a reply carrying selected image IDs but posted only its text, so Fast could claim a screenshot was attached when Discord received no image. Deferred Discord interactions also have a ten-embed per-message limit; larger selections must send additional batches rather than fail the whole reply.

Impact

Discord Fast replies now deliver selected task screenshots instead of silently dropping them, including retry replacement and deferred-interaction overflow paths. The fix does not overlap #3201's artifact-upload notification changes. Focused automated tests cover the Discord payload and session-scoped artifact resolution; visual proof capture timed out, so no screenshots are included.

@roomote-community

roomote-community Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See task

  • Fast can claim an earlier task image is attached on Discord even though its adapter drops imageArtifactIds.
  • Deferred Discord interaction replies with more than ten selected image artifacts fail instead of delivering image batches.

Reviewed 65bbfde

Comment thread packages/cloud-agents/src/server/fast-agent/fast-agent-prompt.ts
@roomote-roomote

roomote-roomote Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor Author
Resolved both Discord image-delivery findings in [0ad6b80](https://github.com/RooCodeInc/Roomote/commit/0ad6b809) and [65bbfde](https://github.com/RooCodeInc/Roomote/commit/65bbfde0). Fast now resolves selected image IDs against the current session, posts Discord embeds on direct and existing-session replies, and batches deferred-interaction overflow beyond ten images. Both review threads are resolved, and the latest Roomote code review check passes with no code issues. Focused API/SDK/Discord-provider tests, typechecks, pre-push checks, and CI passed. Proof handoff: blocked, `proof capture timed out`; no visual proof is included.

Comment thread apps/api/src/handlers/discord/replies.ts Outdated
@roomote-roomote roomote-roomote Bot changed the title [Improve] Make delegated image delivery explicit in Fast replies [Fix] Discord Fast replies fail to attach selected images Sep 24, 2026
@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 24, 2026 16:24
@mrubens
mrubens merged commit 25f5e54 into develop Sep 24, 2026
17 checks passed
@mrubens
mrubens deleted the feature/fast-image-reply-guidance-18p90poobl72m branch September 24, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant