Repository navigation
[Refactor] Consolidate delegated model consent on canonical dialogue - #3449
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See task Reviewed all six changed files, both production resolver callers, canonical consent boundaries, replay snapshots, queued follow-ups, and the remaining reply-retrieval caller. The removed fallback and proposal-recovery mode have no production consumers; the remaining query behavior is unchanged. Current-head CI: Test, Lint, Type Check, Knip, and CodeQL passed. Docker Build (app, amd64) is still running. Reviewed 518727b |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 9, 2026 13:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Maintenance cleanup of the canonical model-request dialogue introduced in #3439; no linked issue.
Why this PR exists
What changed
Both production resolver callers already supply dialogue. This behavior-preserving simplification removes competing evidence contracts without changing authorization policy, classifier thresholds, routing precedence, or snapshot persistence. Net deletion: 85 lines across six files.
How it was tested
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset