Add base feature gating for derive(CoercePointee) - #4841
Open
CohenArthur wants to merge 3 commits into
Open
CohenArthur wants to merge 3 commits into
CohenArthur wants to merge 3 commits into
Conversation
gcc/rust/ChangeLog: * checks/errors/feature/rust-feature-gate.cc (FeatureGate::visit): Add missing call to default visitor for ExternType items.
CohenArthur
added
the
rust-for-linux
…gate. This commit adds more functionality to the BuiltinAttributeChecker class and allows it to store the list of parsed crate features. The class will then keep an instance of FeatureGate, and will be able to gate nightly attributes should it need to. This is particularly useful for checking unstable built-in derives *before* they get desugared and removed by macro expansion. gcc/rust/ChangeLog: * checks/errors/feature/rust-feature-gate.h: Make `gate` public. * checks/errors/rust-builtin-attribute-checker.cc: Make all handlers private methods instead. (lookup_handler): Transform the function to make it return pointer to member functions instead. (BuiltinAttributeChecker::BuiltinAttributeChecker): Add new argument to constructor to take in parsed CrateFeatures&. (BuiltinAttributeChecker::visit): Adapt attribute visitor to new lookup_handler function. * checks/errors/rust-builtin-attribute-checker.h: Add new declaratiosn for handlers. * rust-session-manager.cc (Session::compile_crate): Make BuiltinAttributeChecker run before expansion.
Gate derive(CoercePointee) behind `#
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more functionality to the BuiltinAttributeChecker class and allows it to
store the list of parsed crate features. The class will then keep an instance of FeatureGate,
and will be able to gate nightly attributes should it need to. This is particularly useful for
checking unstable built-in derives before they get desugared and removed by macro expansion.
We then gate derive(CoercePointee) behind
#![feature(derive_coerce_pointee)and start adding theinfrastructure required to support the derive.