Repository navigation
Conversation
Collaborator
|
Sorry for the late review, and thank you so much for the quick update! That said, I would suggest separating vector retrieval and the multi-agent framework into different plugins, rather than integrating both into Decoupling application logic from the framework is, after all, the whole point of a plugin-based architecture. |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build on the backend infrastructure merged in #3, within
packages/dsh-triton-riscv:Related Issue
Follow-up to #3. No issue is closed by this PR.
Validation
Vitest is the single automated test entry point. Existing backend assertions remain behind the established Vitest-to-pytest bridge; direct Vitest coverage checks proposal-role tool denial, SDK credential forwarding, and includes the frontend suite in repository CI. The former Python YAML/JavaScript configuration check is migrated to Vitest with an explicit JS parser dependency, removing the undeclared PyYAML dependency found in the first CI run. This PR does not add a second CI test runner.
With disposable MySQL, Redis, RabbitMQ and Qdrant services configured as described in the plugin README:
Local results:
CI adds a disposable Qdrant service. Automated CI tests require neither model credentials nor access to the private RISC-V server.
Latest GitHub CI run for
5b8754d: bothpre-commitandvitestpassed.Compatibility and Limits
0003through0005after backing up the database.queue.proposalWorkflows; proposals never bypass write or validation approvals.Checklist