fix(server-ws): silence routine auth rejection logs - #371
Draft
Adamskiee wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
WebSocket authentication rejections are expected client input. The warning propagated through the
appactivity logger, whose formatter requires fields such asuser_id, and produced a large logging traceback instead of a concise rejection.The routes already close rejected sockets safely. Leaving these expected rejections silent removes the noisy traceback without changing authentication behavior.
Impact
Invalid-token WebSocket connections continue to be rejected with close code 1008. Operators no longer see warning or formatting tracebacks for routine signalling and GPS authentication failures.
Validation
tests/test_websocket_auth_rejection.py: 8 passedgit diff --check: passedThe full standalone server suite was also attempted. It reached 94 passing tests, with remaining failures caused by the local suite environment and shared test state, including rate-limit exhaustion, missing QA configuration, unavailable Redis, and legacy unauthenticated GPS test expectations.