Repository navigation
feat: collaboration -- delete a routine run's chats with the run - #3846
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deleting a routine run now also deletes the chats that came from it. Before, the run left its history, but its chats stayed in the owner's Chats list.
The latest result's "Ask Assistant" chat now uses the run's own chat, the same one History's "Open chat" opens. That way every chat of a run can be found from the run when the run is deleted.
Changes Made
WorkRoutineRoom.deleteRundeletes these chats before it deletes the run:RemoveUserRoomremoves one: it is marked inactive for the owner, and its agent code context and Redis copy are cleared.WorkDeleteRoutineRunnow returns{ deleted: true, roomIds: [...] }, the rooms it deleted, so the client can leave one that is open.WorkRoutineRoom.openfor the latest result now opens the chat keyed by the run id, not by the routine row's start time. A latest-result chat that already exists keeps opening.WorkRoutineRoomUnitTests.