#772 Animate Tooltips In As Well As Out - #773
Merged
Merged
Conversation
Radix Tooltip never sets data-state="open" on TooltipContent (its open states are delayed-open/instant-open), so the gated enter classes never matched. Make the enter animation unconditional. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cielbellerose
added
ready for review
cielbellerose
commented
Sep 24, 2026
cielbellerose
left a comment
cielbellerose
left a comment
Collaborator
Author
There was a problem hiding this comment.
Code Review — Cycle 1 · approved
0 open — clean
cielbellerose
added
approved
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #772
Summary
Tooltips snapped in with no transition but faded/zoomed out when closing.
TooltipContentgated its enter animation ondata-[state=open], but Radix Tooltip never sets that state — its open states aredelayed-open/instant-open— so the enter classes never matched while the exit classes (gated ondata-[state=closed], which Radix does set) worked fine.Changes
components/ui/tooltip.tsx— made the enter animation (animate-in fade-in-0 zoom-in-95) unconditional onTooltipContent, since Radix only mounts the content while it's showing, so an unconditional enter animation is safe. Exit classes (data-[state=closed]:*) and thedata-[side=*]:slide-in-from-*classes are unchanged.hover-card.tsxorpopover.tsxexist incomponents/ui/;dialog,alert-dialog,sheet,dropdown-menu, andselectall gate on Radixdata-statevalues that are genuinelyopen/closed, so they were left unchanged.Testing plan
components/features/markdown-field.tsx, any markdown field such as a position description form). After ~300ms the tooltip fades and zooms in (previously appeared instantly).position-status-header-actions.tsxon a position page, and the tooltips inusers-table.tsxon the users admin table. Each animates in from the correct side.motion-reduce:override added, matching the pre-existing exit behavior) — no regression versus today.Automated checks
npm run prettier:check— passnpm run eslint:check— passnpm run tsc:check— passNotes
One-line class fix; no behavior change beyond the enter animation now firing.
🤖 Generated with Claude Code