Repository navigation
Autumn 26 batch 2: montage CLI options, EcoTaxa export fix, holo depth fix and docstrings - #445
Merged
Merged
Conversation
Best guesses are only used for the label folder names, so compute them only for --make-label-folders. add_best_guesses_to_stats now raises a clear error when there are no probability columns.
make-montage and make-montage-scaled take --msize. make-montage-scaled gains --filter-variable, sharing one helper with make-montage.
Document n and offset in create_kernel, state the real forward_filter_option and inverse_output_option behaviour, replace the _summary_ placeholders in std_map and max_map, note that find_focus_sobel returns the edge magnitude, add the holo segment_source note, and fix typos.
animmosmith
marked this pull request as draft
October 14, 2026 23:51
MergeStats now reports z[ifocus] (ifocus is zero-based). Focus now discards particles at the last slice. Adds fast synthetic tests and updates the expected particle count in the holo pipeline test.
animmosmith
marked this pull request as ready for review
October 15, 2026 20:58
Merge make-montage-scaled into make-montage: --scaled selects the scaled circular montage, --rel-scale applies only with --scaled. make-montage-scaled is removed. The filter-variable filtering is done inline in the command.
Assert the usage-error exit code instead of matching the error text, which rich splits with colour codes on CI.
nepstad
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
make-montagetakes--msizeand--filter-variable, in both its default and--scaledmodes (775fbc8). Closes Add--msizetomake-montageandmake-montage-scaled, and--filter-variabletomake-montage-scaled#442make-montagecommand:make-montage-scaled(added in 2.18.0) is removed; usemake-montage --scaled [--rel-scale X].make-montagewithout--scaledbehaves as before. The filter-variable filtering is done inline in the command (e23c191)Housekeeping
export-to-ecotaxano longer fails on stats without classifier output. Best guesses are only computed for--make-label-folders, andadd_best_guesses_to_statsnow raises a clear error when there are noprobability_*columns (5c8c039). Closesexport-to-ecotaxacrashes with a numpy error on stats without classifier output #443nandoffsetincreate_kernel(offset is the air-equivalent distance to the sample volume), state the real behaviour offorward_filter_optionandinverse_output_option, replace the_summary_placeholders instd_mapandmax_map, note thatfind_focus_sobelreturns the edge magnitude, add the holosegment_sourcenote toSegment, fix typos (f67cd9c)Checks