Conversation
Author
|
mistakes |
Member
|
Yeah, no. I am not reviewing this behemoth. This is also very ai-generated. These files should be split properly before we even consider decompiling. Closing. |
Member
|
It is worth noting that we will focus more on SMG2 once 1 is completed, which shouldn't take much longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds cumulative SB4E01 source reconstruction and integration across LiveActor, Map, collision, geometry, and supporting utilities. Verified source-integrated code reaches 109,996 / 6,281,816 bytes (1.7510222%), with 272 complete translation units. Exact objdiff code is 168,616 bytes and 1,692 functions; these metrics include original-linked matches and are distinct from source integration.
The changes include source ownership splits, symbol/alignment corrections, supporting declarations, and provenance. Partial implementations remain original-linked. The README and published progress assets retain the earlier 1% milestone snapshot; current verified figures are above. This is an intermediate mixed-source checkpoint, not a fully source-built game.
Validation on the cumulative working tree:
7d79810889824edd01c4ff02624713060a69818c.8dcedb269f4b9164bda6dd11768be1ccd9bb126band verified every publication file against the tested tree after encoding normalization.The local Shift-JIS runner override is excluded. No retail assets or toolchain binaries are included. No gameplay testing was performed. Direct retail reconstruction and external adaptations are distinguished in
docs/PROVENANCE.md.