Repository navigation
feat(recall): add retained history and shared intent briefs with use telemetry - #55
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23f2de6ade
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
entelecheia
force-pushed
the
feat/40-recall-quality
branch
from
October 24, 2026 18:05
23f2de6 to
beee63b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #40
Public recall now omits expired and currently superseded notes. The person can inspect verified retained history through explicitly authorized APIs and CLI flags, while current forget/prune removals hide the text at every date. CLI and MCP share one guarded, fail-first intent brief, and nullable use observations distinguish rendered output from explicit delivery/citation evidence.
F10 / AC5:
F11 / AC6:
F12:
Review changes:
Measured latency (Bun1.4.2, native macOS,3000 synthetic notes,3 samples): reviewed23f2de6 search median1235.19ms and brief3089.72ms; repaired source15dc044 search343.40ms and brief400.10ms. Base main search355.04ms. This is native diagnostic evidence, not a cross-machine guarantee. Reproduce with scripts/measure-recall-latency.ts 3; exact samples/source refs in docs/verification/2026-10-25-amem422-recall-latency.json.
Documented ceilings: retained history50000records/32MiB row-data verification,64member show chain; unknown promotion event time; opened-retained-source diagnostics (unrouted invalid global pre-split rows are not fabricated per shard); advisory filesystem metadata and concurrent ancestor-swap ceiling; call-scoped snapshot consistency; automatic rendered observations at most256 curated ids per output. No new dependency, schema/hash/op/path or authored-row rewrite.
Validation at full headbeee63bd71f54a2351af3f5e0c8d10e80cb9d051 on fresh mainf654574c53306841d93ec57053cf9c2849bb8ebb:
All3Important/all5nits andgeneration diagnostic botP2 addressed. Defaultfuture-clock-skew policy follows the reviewer's explicit ruling, with finite validation and historical-only cutoff.
No publish, merge, real-home mutation, #425 or unrelated backlog implementation.