Repository navigation
feat(memory): reviewed consolidation candidates and cited evidence (Refs #40) - #57
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #40 (F18, F19; task #426).
Consolidation now queues deterministic project-local proposals for person review, and agents can fetch a byte-capped cited evidence bundle without an amem model call.
amem note add. No built-in provider/network client, hook call or model MCP tool.amem_evidenceranks live project-curated rows using the existing FTS/BM25 and tier/recency rule. Complete JSON, including question/header/provenance, fits 256..8192 bytes. Citations are exactmem:<id>references. Capture, repo-only rows, pending/model candidates, foreign shared notes and invalid lifecycle entries cannot fill the item cap. Existing PII, policy/source drift and emitted-only telemetry guards apply. A printed citation never increments cited/delivered.Spec-driven existing-test changes authorized by the planner:
test/mcp.test.ts(three counts/title),test/mcp-cli.test.ts,test/candidate-tools.test.tsandscripts/measure-mcp-budget.tschange 11 to 12 and retain complete by-name assertions includingamem_evidence. No authority/input assertions or resource limits were weakened. R3 additionally renders one evidence bundle in the unchanged corpus and reports evidenceReads.Three deliberate mutants went red in their named regressions: unbounded refresh before placement proof; disabled final policy revision check; and omitted pre-provider source screening.
Validation:
0fc264b6f1c565c41d0455c19ba402ee3a74f8ca, rebased onto released main484816013456a377aed32b77d3f35a03804bbac5; only 26 own files differ.boundary: OK (84 source files); Linux full suite 1536 pass / 5 skip / 0 fail (1541 tests, 154 files, 224.77 s);npm pack --dry-run: 92 files.Same-DGX R2 comparison
Unchanged budget script, Bun 1.4.2, host
dgx-h100-2, three independent runs per revision. Main is484816013456a377aed32b77d3f35a03804bbac5; head is0fc264b6f1c565c41d0455c19ba402ee3a74f8ca. Additional runs were serial and alternated main/head after the other owner's slot release.The failed script reports only that its strict 100 MB guard fired;
>=100is a lower bound, not a fabricated exact peak. All passing runs had zero stalled attempts and no retained owned processes. Both revisions show mixed outcomes, and head is not consistently higher. Under the reviewer's stated classification rule, this is recorded as the inherited-high-water noise tracked by #48/task #434; the original failed gate remains visible. A conservative static plus literal-dynamic dependency walk fromsrc/hooks.tscovered 43 files and found no CLI, consolidation/model module or CandidateStore import. There is no speculative import change.Hosted Ubuntu and macOS checks must still be green before merge. CI is not polled by the implementer.