Skip to content

fix(sync): signal polish from the #435 review (Refs #40) - #60

Merged
entelecheia merged 1 commit into
mainfrom
fix/437-sync-signals
Oct 25, 2026
Merged

entelecheia merged 1 commit into
mainfrom
fix/437-sync-signals

Conversation

@entelecheia

Copy link
Copy Markdown
Member

Task #437, the nits left when PR #54 was approved at a3e74d9. Refs #40.

  • sync.ts (git and generationSyncGit): once the group was signalled, the finally SIGKILLs it before unregistering, so a transport child that ignores TERM does not stay at ppid 1. Test: a fake ssh that traps TERM/INT/HUP; fails without the change.
  • sync --if-due ended by a person's signal now exits like that signal (main re-raises after output; SIGQUIT exits 131); stopSignal reports signalName(); endLikeSignal is shared with doctor's guard.
  • doctor: every memoryGitSync call under doctorReport has a 5 s timeout (withGitTimeout), so a lone kill waits at most one call. Test fails without it (20 s).

Gate: tsc, check-boundary, full bun test (1543 pass, 0 fail), npm pack --dry-run.

Copilot AI balanced review requested due to automatic review settings October 25, 2026 01:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T01:44:45.123207Z bcd9d23 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@entelecheia
entelecheia merged commit 027fddd into main Oct 25, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants