Repository navigation
fix(admission): a busy process outside any repository is host load, not unknown ownership - #295
Merged
Merged
Conversation
…ot unknown ownership (#294) Claude-Session: https://claude.ai/code/session_01KzeWFojtQKhDwcFrqZZv3Z
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
4 tasks
…ect case (#294 review) Claude-Session: https://claude.ai/code/session_01KzeWFojtQKhDwcFrqZZv3Z
… the cwd ceiling (#294 review) Claude-Session: https://claude.ai/code/session_01KzeWFojtQKhDwcFrqZZv3Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #294.
dot admitdeferred agent-hub's local checks five times on 2026-10-20. Each blocker was a background process that runs no build or test in any repository: Maru'sdotfilescommands (cwd/) and claude-mem's one-turn observer (claude --max-turns=1, cwd~/.claude-mem/observer-sessions). The CPU rule (100% or more) caught them. Their cwd lies outside every repository, soRepositorystayed empty, whichfilterUncoveredtreats as unknown ownership, and that blocked every caller.Change, in
internal/admission/uncovered.go:repositoryIdentityreturnserrNotRepositoryonly when the walk reaches the filesystem root without a.git. Permission errors, invalid Git pointers and the 64-level depth cap stay unknown.HeavyJobrecordsCPUOnly(the CPU rule alone matched) andOutsideRepository(the cwd was observed, anderrNotRepositorywas returned).filterUncoveredno longer counts a job that is both as unknown ownership.Unchanged, and still blocking:
The pressure thresholds still count these processes' load.
Tests, red-first: commit 74fabdf adds them alone and fails to build. They cover:
filterUncoveredtable: busy outside a repo, unobserved cwd, shaped outside a repo, maintenance;repositoryIdentitysentinel against an invalid pointer;CPUOnlyforclaudeat 150% versuscargo buildat 150%;Checks:
go testforinternal/admission,internal/resourceguardandinternal/clipasses with GOMAXPROCS=2 -p 2 -parallel 2.go vetis clean.internal/cliTestJSONGoldensfails only whenCLAUDE_CONFIG_DIRpoints outside the preference home (this session's Orca profile); it passes with it unset, so that is environmental and unrelated. Full gate: CI.Review round 1 (read-only reviewer: changes requested; #294 amended with D5, D6 and AC5):
project == "") no longer treats an exempted job as same-repository work.OutsideRepository=true, and one whose cwd was removed resolves to unknown. A nonexistent path is noterrNotRepository. The empty-project case is pinned. The two mutations the reviewer found surviving (outside: false,outside: err != nil) now fail the package tests. TMPDIR inside a repository skips with a reason.~) is recorded as an accepted ceiling indocs/CEILINGS.md, with a pinnedponytailmarker. The pressure thresholds do not cover a single such process on a many-core host.go testfor admission, resourceguard, cli (withCLAUDE_CONFIG_DIRunset) and syncer passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01KzeWFojtQKhDwcFrqZZv3Z