Skip to content

fix(forms): omit inline labels whose value is only placeholders - #395

Merged
entelecheia merged 1 commit into
mainfrom
fix/slots-forms-inline-label-slot
Sep 27, 2026
Merged

entelecheia merged 1 commit into
mainfrom
fix/slots-forms-inline-label-slot

Conversation

@entelecheia

Copy link
Copy Markdown
Member

Closes #385

Summary

hwp slots --forms listed an inline 라벨: 값 label as a form field even when the text after the label was only placeholder(s) (목표: {{최종목표}}). hwp fill --forms defers such a label to the placeholder, so a caller that sends a value for every scanned field always got those labels back as unmatched with counts of 0, and a value typed into them was dropped.

scan_form_fields now skips an inline label whose value text is only slot(s) and whitespace — the slot is already listed as its own field. A label with text of its own next to a slot (전략: 올해 {{추진전략}} 중심) still lists.

Verification

  • New unit test skips_an_inline_label_whose_value_is_only_slots (hwp-convert) and CLI regression slots_forms_skips_a_label_that_only_names_a_slot (tests/form_fields.rs).
  • Full workspace suite: cargo test --offline --workspace — all green (no failures).
  • Acceptance on the Maru fixture from the issue (src-tauri/testdata/hwp-cli-plan-template.hwpx): slots --forms --json went from 26 fields (inline labels 목표/전략/효과 included) to 23 fields with none of those three; fill --forms --allow-partial with a value for every scanned key reports 26 replacements, verification OK, and no scan-produced unmatched key.
  • No schema under schemas/ changed bytes.

Release note

Worth a v1.3.1 patch: this is a slots --forms output narrowing that removes keys callers could never fill; Maru's Studio fill (maru#380) benefits directly.

Copilot AI balanced review requested due to automatic review settings September 27, 2026 07:56

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped: your organization has reached its API usage limit, so Code Review can't run right now.

An organization admin can review the limit in your organization's usage and billing settings.

Once the limit resets or is raised, reopen this pull request to trigger a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-27T07:59:03.937091Z 23da077 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 23da077506

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/hwp-convert/src/form.rs Outdated
@entelecheia
entelecheia force-pushed the fix/slots-forms-inline-label-slot branch from 6fc8462 to f9aef6b Compare September 27, 2026 08:52
@entelecheia
entelecheia merged commit 3612f0d into main Sep 27, 2026
5 checks passed
@entelecheia
entelecheia deleted the fix/slots-forms-inline-label-slot branch September 27, 2026 09:03
entelecheia added a commit that referenced this pull request Sep 27, 2026
Rebind the CHANGELOG [1.3.1] verification block to readiness run 36309366056, which evaluated 39aaa4e (21 gates, pass), after #395 invalidated the first evaluation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

slots --forms lists inline labels whose value is a slot, and fill --forms always reports them unmatched

2 participants