Repository navigation
fix(forms): omit inline labels whose value is only placeholders - #395
Conversation
There was a problem hiding this comment.
An organization admin can review the limit in your organization's usage and billing settings.
Once the limit resets or is raised, reopen this pull request to trigger a review.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23da077506
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6fc8462 to
f9aef6b
Compare
Closes #385
Summary
hwp slots --formslisted an inline라벨: 값label as a form field even when the text after the label was only placeholder(s) (목표: {{최종목표}}).hwp fill --formsdefers such a label to the placeholder, so a caller that sends a value for every scanned field always got those labels back asunmatchedwith counts of 0, and a value typed into them was dropped.scan_form_fieldsnow skips an inline label whose value text is only slot(s) and whitespace — the slot is already listed as its own field. A label with text of its own next to a slot (전략: 올해 {{추진전략}} 중심) still lists.Verification
skips_an_inline_label_whose_value_is_only_slots(hwp-convert) and CLI regressionslots_forms_skips_a_label_that_only_names_a_slot(tests/form_fields.rs).cargo test --offline --workspace— all green (no failures).src-tauri/testdata/hwp-cli-plan-template.hwpx):slots --forms --jsonwent from 26 fields (inline labels 목표/전략/효과 included) to 23 fields with none of those three;fill --forms --allow-partialwith a value for every scanned key reports 26 replacements, verification OK, and no scan-producedunmatchedkey.schemas/changed bytes.Release note
Worth a v1.3.1 patch: this is a
slots --formsoutput narrowing that removes keys callers could never fill; Maru's Studio fill (maru#380) benefits directly.