Repository navigation
docs(archify): regenerate hwp-cli architecture with archify 3.0 - #405
Merged
Merged
Conversation
Pinned revision: 1989573 (origin/main, v1.3.1), up from 982c3e6 (45 commits). Content changes: - Split a shared command layer out of the CLI entry: clap dispatch and the 22 MCP tools both run crates/hwp-cli/src/commands. - File IO now follows its real owners: codecs open inputs and write hwp/hwpx by path; the command layer stages, verifies and renames every output. hwp-convert and hwp-render return bytes and no longer draw a direct filesystem edge. - Remote edge covers both deploy tiers (Cloudflare Worker with OAuth/PAT, AgentCore), both images pinned to v1.3.1. - Added Korean form-field scan/fill (slots --forms, fill --forms, kordoc port), the shared slot grammar in hwp-model, and drawing-object text rows in render-layout-v1. - --root path checks are qualified: always on for hwp serve, unrestricted for hwp mcp without --root. - Recounted at the pin: 26 CLI commands, 22 MCP tools, 10 lint rules, 6 official-document profiles. Dropped the fixed 1376px viewBox. Gates: finalize (validate, deliver, strict check, browser-check) pass with --repo-root evidence; visual-check pass with --require-provenance.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
An organization admin can review the limit in your organization's usage and billing settings.
Once the limit resets or is raised, reopen this pull request to trigger a review.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Archify 3.0 retired meta.views: renderers ignore it, so the three views declared guided paths the HTML never showed. Removed them. The only view note fact not already in a card (MCP tools run the CLI's command code) is folded into the MCP and deployment card; the other two notes duplicated card text and were dropped. Review findings: PR #405 has no review threads. Codex completed with no findings; the Claude and Copilot reviews were skipped over quota. Pin unchanged at 1989573. Gates: finalize (validate, deliver, strict check, browser-check) pass with --repo-root; visual-check pass with --require-provenance.
- MCP file IO: serve /files writes uploads straight to root.join(name)
and hwp_get_file reads directly (mcp/http.rs 364-456, mcp/mod.rs
1028-1060). Added an mcp -> fs edge ("/files, get_file") and reworded
the Core card: command outputs and hwp_put_file are staged, verified,
renamed; /files writes in place.
- Codecs tag "byte-exact hwp5" became "unedited hwp5 lossless", cited to
crates/hwp5/tests/identity.rs; the Core card now scopes the guarantee to
unedited hwp-origin files (README Limitations).
- JPEG and WebP are encoded in the command layer (commands/render.rs
640-672), not hwp-render: render tag is now "PNG/SVG/PDF pages" and the
encode site is cited on the command layer.
- segment_map.rs source relabelled "per-page segment geometry rows"; the
render-layout-v1 name belongs to hwp-cli's render_layout.rs.
- MCP card no longer says tools run the CLI's command code: mcp/mod.rs:7
says they wrap the library layer, not commands/*::run; they reuse the
command modules' execute and publish helpers.
- Shortened the security-group title to "--root gate" so the
cli -> mcp arrowhead is no longer hidden under it.
Pin unchanged at 1989573 (v1.3.1-5-g1989573).
Gates: finalize (validate, deliver, strict check, browser-check) pass with
--repo-root; visual-check pass with --require-provenance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Archify 3.0 fails the 2.x spec on
composition/desktop-readability(fixed 1376px viewBox) and verifies repository evidence against committed bytes at a pinned revision. This regeneratesdocs/architecture/hwp-cli*at1989573f62ae1db4176caa43d232c8094dc0673a(v1.3.1-5-g1989573: five CI/deploy commits after the v1.3.1 tag; the workspace version in Cargo.toml is 1.3.1), 45 commits past the old pin982c3e63.Content changes:
crates/hwp-cli/src/commands) now sits between the clap entry and the crates; the 22 MCP tools reuse the command modules' execute and publish helpers (not their stdoutrunpaths).hwp_put_file), andhwp serve --filesuploads andhwp_get_filehit the root directly (MCP -> fs edge). The oldhwp-convert -> fsandhwp-render -> fsedges were wrong (those crates return bytes) and are gone.slots --forms,fill --forms, kordoc port), the shared slot grammar in hwp-model, and drawing-object text rows in render-layout-v1.--rootpath checks are qualified: always on forhwp serve, unrestricted forhwp mcpwithout--root.meta.views(archify 3.0 renderers ignore them, so the spec declared guided paths the HTML never showed). The one uncovered fact, that MCP tools run the CLI's command code, moved into the MCP card.Verification
archify finalize architecture hwp-cli.architecture.json hwp-cli-rendered.html --repo-root <worktree> --quality showcase --json: pass (validate, deliver, strict check, browser-check), no diagnostics, no crossover hints.archify visual-check hwp-cli-rendered.html --summary --require-provenance --out-dir docs/architecture: pass (containment, readability, viewer chrome, theme states, captures).tools/callandatomic publishverticals under the Command layer run about 15px apart, still readable.ce35cae: finalize pass (0 diagnostics), visual-check pass; the 1440x900 light capture is unchanged in layout.1a715c7: finalize pass (0 diagnostics), visual-check pass. Fixes: MCP -> fs edge for/filesandhwp_get_file; codecs tag scoped to unedited hwp5 and cited tocrates/hwp5/tests/identity.rs; JPEG/WebP moved from hwp-render to the command layer (commands/render.rs640-672); segment_map citation relabelled (render-layout-v1 is named inrender_layout.rs); security-group title shortened so thehwp mcp | servearrowhead is visible.hwp-cli-rendered.visual-check.json;grep -l '/Users/'over the staged files prints nothing.Checklist
scripts/check.sh: not run, docs-only change (no Rust, schema or fixture files touched)🤖 Generated with Claude Code