Repository navigation
fix(config): keep config fingerprints stable when exporter_firewall is unset - #85
Merged
Merged
Conversation
…s unset The new exporter_firewall key was encoded without omitempty, so every host's effective config gained "exporter_firewall: false" and no longer matched the fingerprint recorded by its last apply. fleet update then stopped at the first host as unverified. Pin the fingerprint of a minimal config so a future key cannot change it unnoticed. Claude-Session: https://claude.ai/code/session_0177Zk7to4EYohgM59v4Fcj7
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c33bf8b1b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
v0.18.0 added
modules.monitoring.exporter_firewallwithoutomitempty. The fingerprint hashes the YAML encoding of the effective config, so every host now encodesexporter_firewall: falseand no longer matches the fingerprint its last apply recorded.rootfiles fleet update --all --version v0.18.0stopped at a100: "remote config fingerprint is missing; inventory configuration is unverified".Fix
omitemptyon the key, so configs that do not set it encode as before.TestFingerprintStableAcrossReleasespins the fingerprint of a minimal config to the value v0.17.1 computes; it fails without the fix.Verification
fleet/a100.yamlfingerprints to49cc1f52..., the value in a100's/var/lib/rootfiles/state.json.go test ./...passes.Rollout follow-up for #83.
🤖 Generated with Claude Code
https://claude.ai/code/session_0177Zk7to4EYohgM59v4Fcj7