Repository navigation
Add native shortcut editor with popup capture and immediate saves - #285
Draft
Guffawaffle wants to merge 55 commits into
Draft
Guffawaffle wants to merge 55 commits into
Guffawaffle wants to merge 55 commits into
Conversation
This was referenced Sep 16, 2026
Guffawaffle
changed the title
…ion first (without held SPUD history)
…out held SPUD history)
…thout held SPUD history)
Guffawaffle
force-pushed
the
feature/mod-shortcut-settings
branch
from
September 28, 2026 00:00
0806e20 to
0d08142
Compare
# Conflicts: # xmake.lua
…ml-editor # Conflicts: # docs/config-save.md
…gs-navigation # Conflicts: # example_community_patch_settings_en.toml # mods/src/config.h # mods/src/defaultconfig.h # mods/src/patches/patches.cc
…ngs-controls # Conflicts: # docs/MOD_SETTINGS_NAVIGATION.md # mods/src/config.cc # mods/src/config.h # mods/src/patches/parts/forbidden_tech_confirmation.cc # mods/src/patches/parts/hotkeys.cc # mods/src/patches/patches.cc
# Conflicts: # mods/src/patches/parts/mod_confirmation_settings.cc
# Conflicts: # mods/src/settings/native/action_widgets.cc
# Conflicts: # mods/src/settings/native/action_widgets.cc
# Conflicts: # example_community_patch_settings_en.toml # mods/src/config.h # mods/src/defaultconfig.h # mods/src/patches/patches.cc
# Conflicts: # mods/src/config.cc # mods/src/config.h # mods/src/defaultconfig.h # mods/src/patches/patches.cc
# Conflicts: # mods/src/patches/patches.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Settings → Mod Settings → Shortcuts, with registered actions grouped by purpose. Add and Change open a capture popup with overlap warnings and Confirm/Use anyway. Escape closes only the popup; focus loss or page departure discards the draft. Input stays owned through key release, and Enter remains bindable while recording.
Remove and Restore save immediately. An amber Undo notice restores the exact previous list unless a newer edit superseded it. Alternative bindings, aliases, comments and unrelated settings are preserved; failures use the shared settings notice. Current documentation reflects popup confirmation and immediate list operations, with no page-level Apply step.
Depends on #269 and corrected #282. Following #313, native settings, runtime persistence, Forbidden Tech and fleet-label installation inherit their independent patch switches and registry ownership. Shortcut bindings and keyboard_layout_mode remain feature configuration. The popup uses the existing frame dispatcher; no additional ScreenManager detour is added. The native adapter supports Windows x64 and macOS, with layout-aware capture on Windows and physical keys on macOS.
Validation: Windows release build, existing shortcut/settings and full persistence fixtures, keyboard mapping/chord fixtures and all example TOMLs pass. Three independent reviews cover the complete candidate. Earlier downstream popup/Undo smoke is historical; exact-candidate native popup, input-release/pooling and macOS runtime qualification remain open. CI starts on publication without waiting for results.