Skip to content

fix(packages/sui-bundler): keep plainCssPackages rules out of the link sass loader #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasmax merged 1 commit into from
Aug 18, 2026
Merged

fix(packages/sui-bundler): keep plainCssPackages rules out of the link sass loader #1994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/sui-bundler/loaders/linkLoaderConfigBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,20 @@ module.exports = ({config, packagesToLink, linkAll}) => {

if (!regex.test('.css')) return rule

if (!Array.isArray(use)) return rule

/**
* Only rules that already pipe through @s-ui/sass-loader need its importer
* replaced. Rules that don't (like the plainCssPackages passthrough) must be
* left untouched: injecting the sass loader there makes Sass parse plain CSS
* that isn't valid SCSS (e.g. Tailwind v4 output) and the build fails.
*/
const usesSassLoader = use.some(loaderEntry =>
(typeof loaderEntry === 'string' ? loaderEntry : loaderEntry?.loader || '').includes('@s-ui/sass-loader')
)

if (!usesSassLoader) return rule

return {
...rule,
use: [...use.slice(0, -1), sassLoaderWithLinkImporter]
Expand Down
Loading