Repository navigation
Fix Sarvam final reporting and test ordinary approval controls - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous native-history finalizer admitted requests but base105B returned empty final content. The new reporting boundary preserves every original message/tool receipt as JSON data with role labels and exposes no executable tools. Both fixed models now return the correct receipt-grounded answer in both output formats (4/4 calls on two saved histories). Base consumes substantially more reasoning tokens; this is compatibility evidence, not a matched-compute benchmark gain.
A separate research-only SQLite backend enforces server-owned approval scope, validity and revocation atomically with version/idempotency checks. All 15 deliberately unapproved attempts in the frozen offline comparison are blocked while three legitimate first writes are preserved. All 44 variants across 22 cases match the frozen contract. This does not establish that the model avoids unsafe attempts or that a new memory architecture is needed.
Validation: 75 focused tests including concurrent writes/rollback, Ruff/diff checks, and clean Git export verification of all 113 artifact hashes, four raw API answers, actual SQLite states and cumulative metering. Four new calls, no errors/retries; estimated usage INR0.346440. Historical artifacts and English/default runtime unchanged. Three independent commits separate finalizer, approval backend and evidence. Larger native-model integration/comparison is still pending; no production authentication or broad language-accuracy claim.