feat: make CLI dependencies optional - #421
Merged
Merged
Conversation
Signed-off-by: John <john@mail.build>
Signed-off-by: John <john@mail.build>
|
@SaladDay 你好,非常感谢开发这么棒的一个项目,我们在基于 cc-switch-cli 封装一个 napi-rs 的包装层,方便 Node.js 调用,napi-rs 这层就可以不依赖于 cli feature(可以减小包体积),希望官方可以考虑下 cli feature optional 的这个 PR。 |
Signed-off-by: John <john@mail.build>
Owner
|
@cindyrui71 @bytemain Thank you for the contribution and for explaining the napi-rs use case. This has now been merged. The Thanks again for helping improve cc-switch-cli! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cliCargo feature and require it for thecc-switchbinarydefault-features = falseDefault builds remain unchanged: the
clifeature is enabled by default.Validation
cargo checkcargo test --lib --no-runcargo test --bin cc-switch --no-runcargo check --lib --no-default-featurescargo check --lib --no-default-features --features test-hookscargo test --lib --no-default-features --no-runcargo fmt --checkgit diff --check.github/workflows/rust-ci.ymlas YAMLNotes
cargo clippystill reports the existing reversed-empty-range lint insrc/cli/tui/ui/home_chart.rs; this change does not touch that code.