Skip to content

fix(ci): cover shared server inputs in backend proposal - #310

Merged
SamGu-NRX merged 1 commit into
obv/burst11-bs-backend-ci-proposalfrom
gpt-burst/1022w2-pr288-path-filter
Oct 22, 2026
Merged

SamGu-NRX merged 1 commit into
obv/burst11-bs-backend-ci-proposalfrom
gpt-burst/1022w2-pr288-path-filter

Conversation

@SamGu-NRX

Copy link
Copy Markdown
Owner

Fix the remaining path-filter gap on #288. The proposed backend workflow now triggers for both backend/** and shared server/** changes on push and pull request, so edits to server/solver.py and server/schemas/result.schema.json cannot skip backend checks. The portability test asserts both event filters contain server/** and failed on the owning head before the change.

Verification: uv run --frozen --extra api pytest -q tests/test_ci_proposal_portability.py --tb=short (9 passed), Ruff check/format check, and git diff --check.

Stacked on #288.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f7f73904-924d-4cbf-be82-0c8091619271

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XS 0-9 effective changed lines. label Oct 22, 2026
@SamGu-NRX

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-22T17:05:07.548569Z
We couldn’t complete this review. Comment @codex review to try again.
44c6879 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SamGu-NRX
SamGu-NRX marked this pull request as ready for review October 22, 2026 17:02
@SamGu-NRX
SamGu-NRX merged commit a748f65 into obv/burst11-bs-backend-ci-proposal Oct 22, 2026
4 checks passed
@codemetrics-ai

Copy link
Copy Markdown

Note

Review skipped

Codemetrics is installed on this repository, but it hasn't been added to your team yet.

To enable AI code reviews for this repo, go to your dashboard and add BaseScanning to your team's repositories.

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

The proposed backend workflow now runs for server/** changes on push and pull requests.

  • Backend CI also matches changes in the shared server tree.

Reviews (1) · Last reviewed commit: "fix(ci): cover shared server inputs in b..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant