Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What changed
With
HSS_INGEST_MAX_FILES=1, PR #323's two-request bucket refused a valid review page's third resource. This stacked fix adds a floor for one gallery and ten fixed requests: the module, preview fetch, four verdicts, criteria report, two result JSONs, and preview download.The fix is in
backend/server/api/routes/result.py:250-274. The 2x factor has no traffic evidence. The limiter counts per process: N containers allow N times the budget.Why
A small ingest file limit must not prevent a valid review page from loading. This PR targets #323 and is stacked on
gpt-burst/1022z-bs-284-rest.Verification
From
backend/,env -u NODE_ENV OMP_NUM_THREADS=1 uv run pytest -q server/api/tests/test_review_view.py::test_one_photo_page_loads_all_resources_with_one_file_limitfailed on70ad39ffwith a 429 at the third resource. After the fix, its eleven linked requests all returned 200 with the limiter clock frozen.env -u NODE_ENV OMP_NUM_THREADS=1 uv run pytest -q server/api/tests/test_review_view.py server/api/tests/test_result_boundary.pypassed: 35 tests. Ruff check and formatting passed for both changed files.Risk
The floor counts today's fixed resources. The existing 2x allowance remains unchanged for larger galleries. Neither that factor nor multi-container traffic has been measured.
Checklist
Generated with Claude Code