Repository navigation
IFC property set file: map Revit parameters into standard Pset_* properties - #76
Merged
Merged
Conversation
…e-based host The face-based template's host extrusion came first and gave no face reference, so the pipe, duct and electrical connectors were never created. The newest extrusion is the box. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…properties the IDS checks The Builder's Revit IFC property set file only had the OpenBEP set, so fans, panels and windows failed IDS checks on Pset_FanTypeCommon, Pset_ElectricalDeviceCommon and Pset_DoorWindowGlazingType even though the values were in the model. Size stays out: it is formatted text, not one number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CzZAvEtLFnoGRhte7SjWW6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: The Builder's Revit IFC property set file had only the OpenBEP set. In the live Revit test, fans, panels and windows failed IDS checks on Pset_FanTypeCommon.NominalAirFlowRate, Pset_ElectricalDeviceCommon.RatedCurrent / RatedVoltage and Pset_DoorWindowGlazingType.VisibleLightTransmittance, even though Flow, Mains and Voltage had values in the IFC.
After: For every standard property the IDS checks, the file also has a Pset_* block that copies in the matching Revit parameter (for example Flow → NominalAirFlowRate on IfcFan). These blocks go on occurrences only, the same as the OpenBEP set. Size is left out because it is formatted text such as "300x200", not one number.
How: idsFacet records the Revit source name for Pset_* targets, and idsPsetTxt groups them by property set on the element type's IFC classes. The school example test files are regenerated.
Generated by Claude Code