Repository navigation
IDS: check Revit built-in values in the OpenBEP set, drop duplicate Pset_* blocks - #77
Merged
Merged
Conversation
…e-based host The face-based template's host extrusion came first and gave no face reference, so the pipe, duct and electrical connectors were never created. The newest extrusion is the box. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…properties the IDS checks The Builder's Revit IFC property set file only had the OpenBEP set, so fans, panels and windows failed IDS checks on Pset_FanTypeCommon, Pset_ElectricalDeviceCommon and Pset_DoorWindowGlazingType even though the values were in the model. Size stays out: it is formatted text, not one number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CzZAvEtLFnoGRhte7SjWW6
…FC type Revit writes its own Pset_FanTypeCommon / Pset_ElectricalDeviceCommon on the occurrence; a second set of the same name there hides ours from IDS checkers. On the IFC type the checker merges it into the occurrence's set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CzZAvEtLFnoGRhte7SjWW6
…fill the standard property Revit writes its own Pset_FanTypeCommon / Pset_ElectricalDeviceCommon and a user-defined set of the same name only adds a duplicate that IDS checkers skip. The check now accepts either the standard property or the Revit parameter in the OpenBEP set, and the property set file drops the duplicate Pset_* blocks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CzZAvEtLFnoGRhte7SjWW6
…set only A check listing both Revit's Pset_* set and OpenBEP fails on Revit's set when it lacks the property (ifctester reads every matching set). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CzZAvEtLFnoGRhte7SjWW6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: The fan airflow and panel rated current checks failed in the live Revit test. Revit writes its own Pset_FanTypeCommon / Pset_ElectricalDeviceCommon without those values. Our same-named user-defined set was a duplicate that IDS checkers skip, and a check listing both sets fails on Revit's.
After: A Revit built-in parameter with a standard IFC target is checked in the OpenBEP set under its Revit name (for example OpenBEP.Flow, OpenBEP.Mains), like other built-in parameters. The IFC property set file no longer writes duplicate Pset_* blocks. In the live Revit 2022 test on the school example, 10 of 12 element types now pass (was 9). The remaining fails are model data: window light transmittance is empty with a schematic glazing type, panel voltage is connector-driven, and two panel parameters are missing from the test family.
How: idsFacet returns an OpenBEP facet for these rows, and idsPsetTxt goes back to a single OpenBEP block. The school example IDS and property set file are regenerated.
Generated by Claude Code