Repository navigation
Fix CI: make staging-retention test self-contained - #2
Merged
Merged
Conversation
test_build_retains_staging_directory_after_failure pointed jrutil_root and geodata_root at sibling checkouts beside the repo. Those exist on a dev machine but not in CI, so build config validation failed before the fixture download error could be raised. Use tmp_path directories instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015J2ywEJDXRpvxW8hbnGdKF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
mainis red.tests/unit/test_national_jdf.py::test_build_retains_staging_directory_after_failurefails with:The test set
jrutil_rootandgeodata_rootto sibling checkouts next to the repo (WORKSPACE / "jrutil",WORKSPACE / "jrunify-ext-geodata" / "other"). Those directories exist on a dev machine but not on the CI runner. Because of that,_validate_build_configrejects the config before the test reaches the download failure it is meant to check.This PR has the test create both directories under
tmp_path, and it removes theWORKSPACEconstant, which nothing else used. No production code changes.Test plan
uv run pytest: 72 passeduv run ruff check .,uv run ruff format --check .anduv run pyrightare clean🤖 Generated with Claude Code
https://claude.ai/code/session_015J2ywEJDXRpvxW8hbnGdKF
Generated by Claude Code