Repository navigation
Conversation
Inputs with weight 0, and all inputs when input weights are turned off, were left out of the objective. Byproducts cost nothing, so once an input exceeded the demand the solver could draw it and dump it into a byproduct at no cost. Every input now carries a 1e-6 tie-break cost on top of its weight. That's far below any real weight (water: 0.01) and far above the 1e-9 dual tolerance, so it only breaks ties. 'Add to inputs' goes back to weight 0 now that free inputs behave.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2
one remark: this PR includes a fix for inputs with weight 0. Previously inputs with weight 0 were drawn into the solver because byproducts are free. This resulted in inputs being displayed like this:
Steps to reproduce (on
master)If you'd rather split the fix from the feature, I can do that. Just felt like they belong together.