Repository navigation
test(smoke): adopt playwright-config 2.1.0's clipped-box and split-word checks - #348
Merged
Merged
Conversation
…rd checks `expectNoHorizontalOverflow` 2.1.0 asks every `overflow-x: hidden | clip` box whether its content is wider than it is, which is the clipping half of the local `expectNoClippedInlineOverflow` that #347 added because the 2.0 helper only measured the document (and under `<main>`'s `overflow-x: hidden` the document never overflows). That half is deleted and the shared helper does it. No `ignore`: `.strip`, the poster shelf, computes `overflow-x: auto`, so the shared helper never flags it; `#sub`'s ellipsis is skipped by the helper itself. The SCROLLING half stays, renamed `expectNoStrayInlineScroller`: the shared helper leaves `auto`/`scroll` alone on purpose (a fleet table scrolls), but in this app `.strip` is the only deliberate sideways scroller and any other is a defect (`.chfilters-scroll`). narrow-scroll-test holds that rule at 390 and 320 only, over a fixture with empty board-game routes; the smoke holds it on every route, data painted, in all four windows. Every route now also runs `expectNoSplitWords`. All 52 tests pass in four windows with no new failure. Negative controls at 384px: a 600px box in `#collection-grid` fails with "main holds 617px in 384px", and an h2 breaking "Extraordinarily" fails the split-word check. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Visual regression — queuepilot (
|
| changed | new | deleted | unchanged |
|---|---|---|---|
| 0 | 0 | 0 | 48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@charcuterie/playwright-configgoes from^2.0.0to^2.1.0.@playwright/teststays at~1.62.1.expectNoHorizontalOverflowfor clipped boxes. Version 2.1.0 also checks everyoverflow-x: hidden | clipbox. That is the clipping half of the local check that test: browser smoke over every route in four windows #347 added, so this PR deletes that half.ignoreis needed..strip(the poster shelf) computesoverflow-x: auto, and the shared helper does not check scrollers. The helper itself skips the#subellipsis box.expectNoStrayInlineScroller. The shared helper does not checkauto/scrollboxes on purpose, because a fleet table scrolls. In this app,.stripis the only intended sideways scroller, so any other scroller is a defect (for example,.chfilters-scroll).narrow-scroll-testchecks this rule only at 390 and 320, and its fixture leaves the board-game routes empty. The smoke checks it on every route with data, in all four windows.expectNoSplitWords.New failures and verdicts
There are no new failures. All 52 tests passed, in all four windows, on two complete runs.
The new checks do find defects in this app. I added two temporary injections at 384px and removed them before the commit:
#collection-gridfailed with:main#_r_0_.charcuterie-scrollbar.relative holds 617px in 384px.h2that breaks "Extraordinarily" failed the split-word check.Screenshots
I examined the screenshots for all 12 routes in the narrow window. The new checks found no defects. Two things already existed before this PR:
/pending, the intro text wraps in a narrow column beside "Mark all as seen". The text is readable, and no check flags it.🤖 Generated with Claude Code