Repository navigation
Add Rosenbrock ReverseDiffAdjoint regression coverage - #4255
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Member
Author
|
Superseded CI note for the previous head: the branch has now been rebased onto current master, which includes the DiffEqBase/SciMLBase blocker fix from #4253. The over-broad OrdinaryDiffEq |
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
fix-4248-rosenbrock-tracked-k-cache
branch
from
August 14, 2026 10:44
d93c4c4 to
33b4558
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Add a regression test for an out-of-place
Rosenbrock23(autodiff = AutoFiniteDiff())solve differentiated withReverseDiffAdjoint(). The test covers the failure reported in #4248 without adding a container-conversion workaround to OrdinaryDiffEq.The underlying bug belongs to
ArrayInterface.restructure: aReverseDiff.TrackedArraytemplate combined with anArray{TrackedReal}source fell through to the generic implementation and lost the tracked-array wrapper. The owner-package fix is already merged in JuliaArrays/ArrayInterface.jl#498, but is not yet in a tagged ArrayInterface release. Do not merge this PR until an ArrayInterface release containing that fix is available.Failing before
Using released ArrayInterface v7.28.1 with the OrdinaryDiffEq regression test:
A direct ArrayInterface reproducer on v7.28.1 showed:
This also confirms why an unconditional downstream
aos_to_soais incorrect: theArray{TrackedReal}template must remain anArray.Passing after the owner fix
With ArrayInterface commit
58f1c4f9ab203ff6e8c0628575b09b2e1e7edab2from the merged owner fix:The same OrdinaryDiffEq command then passed:
Additional validation performed:
Runic, typos, and
git diff --checkpass on the final diff.Not verified
GROUP=Everythingwas not run.ReverseDiff is MIT licensed: https://github.com/JuliaDiff/ReverseDiff.jl/blob/master/LICENSE.md
Closes #4248