Skip to content

Re-enable the Downstream adjoint test - #658

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:test/reenable-downstream-adjoints
Sep 25, 2026
Merged

ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:test/reenable-downstream-adjoints

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Summary

SciML/SciMLBase.jl#1297 has merged and registered SciMLBase 3.x declares RecursiveArrayTools = "4", so the TODO that kept Downstream/adjoints.jl commented out is satisfied. This restores the Downstream Adjoint safetestset and puts back the ForwardDiff / SciMLBase entries in test/Downstream/Project.toml that were removed while waiting on that compat bump.

Verification

export TMPDIR=/home/crackauc/sandbox/goals/qa-hygiene/jobs/rat-tests/tmp
export JULIA_DEPOT_PATH=/home/crackauc/sandbox/goals/qa-hygiene/jobs/rat-tests/scratch/julia_depot
GROUP=Downstream julia --project -e 'using Pkg; Pkg.test()'

Observed (excerpt):

Test Summary:            | Pass  Total     Time
Downstream Adjoint Tests |    1      1  2m24.7s
...
Test Summary:              | Pass  Total     Time
DiffEqArray Indexing Tests |  358    358  8m13.5s
     Testing RecursiveArrayTools tests passed
EXIT=0

Also confirmed: gh pr view 1297 -R SciML/SciMLBase.jl → MERGED; SciMLBase Project.toml / registry Compat has RecursiveArrayTools = "4" under [3].

Not verified

  • Other CI groups (Core, GPU, AD, QA, NoPre) were not re-run for this change.
  • LTS / Julia 1.x matrix beyond the local Julia 1.12.4 Downstream run.

Please ignore this draft until reviewed by @ChrisRackauckas.

Risk assessment

  • Risk: Low — restores a previously intentional Downstream test once its upstream blocker cleared; no production code changes.
  • Blast radius: Downstream CI group only (test/runtests.jl Downstream body + Downstream env deps).
  • Evidence: Full GROUP=Downstream Pkg.test() passed locally including the re-enabled adjoint safetestset.
  • Independent review: Claude Code (Opus 5.5 subagent) rated it low, high confidence: test-only change; reran GROUP=Downstream on the PR head (Downstream Adjoint Tests 1/1, DiffEqArray Indexing 358/358, tests passed); added deps ForwardDiff and SciMLBase are MIT. VERDICT MERGE.
  • Merge: needs review

Harness: Cursor Agent CLI 2026.09.18-9a7762b; model: auto; transcript: /home/crackauc/sandbox/goals/qa-hygiene/jobs/rat-tests/log.txt on amdci2

Made with Cursor

SciML/SciMLBase.jl#1297 merged and SciMLBase 3.x declares RecursiveArrayTools
compat 4, so restore Downstream/adjoints.jl and the ForwardDiff/SciMLBase
test deps that were dropped while waiting on that bump.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Cursor Agent <noreply@cursor.com>
Agent-Harness: Cursor Agent CLI 2026.09.18-9a7762b
Agent-Model: auto
Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/rat-tests/log.txt on amdci2
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review September 25, 2026 02:16
@ChrisRackauckas
ChrisRackauckas merged commit bcefcf6 into SciML:master Sep 25, 2026
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants