Repository navigation
Re-enable the Downstream adjoint test - #658
Merged
ChrisRackauckas merged 1 commit intoSep 25, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
SciML/SciMLBase.jl#1297 merged and SciMLBase 3.x declares RecursiveArrayTools compat 4, so restore Downstream/adjoints.jl and the ForwardDiff/SciMLBase test deps that were dropped while waiting on that bump. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.09.18-9a7762b Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/rat-tests/log.txt on amdci2
ChrisRackauckas
marked this pull request as ready for review
September 25, 2026 02:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SciML/SciMLBase.jl#1297 has merged and registered SciMLBase 3.x declares
RecursiveArrayTools = "4", so the TODO that keptDownstream/adjoints.jlcommented out is satisfied. This restores the Downstream Adjoint safetestset and puts back theForwardDiff/SciMLBaseentries intest/Downstream/Project.tomlthat were removed while waiting on that compat bump.Verification
Observed (excerpt):
Also confirmed:
gh pr view 1297 -R SciML/SciMLBase.jl→ MERGED; SciMLBase Project.toml / registry Compat hasRecursiveArrayTools = "4"under[3].Not verified
Please ignore this draft until reviewed by @ChrisRackauckas.
Risk assessment
test/runtests.jlDownstream body + Downstream env deps).GROUP=DownstreamPkg.test()passed locally including the re-enabled adjoint safetestset.Harness: Cursor Agent CLI 2026.09.18-9a7762b; model: auto; transcript: /home/crackauc/sandbox/goals/qa-hygiene/jobs/rat-tests/log.txt on amdci2
Made with Cursor