Repository navigation
Run ode_gpu.jl in the GPU test group - #659
Merged
ChrisRackauckas merged 2 commits intoSep 26, 2026
Merged
Conversation
ode_gpu.jl has existed since 2022 but was never included from the GPU group; wire it in and add OrdinaryDiffEq (plus LinearAlgebra) to the GPU test env so the file can resolve. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.09.18-9a7762b Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/rat-tests/log.txt on amdci2
Add minimal @test coverage so the newly wired GPU ODE smoke file fails on wrong results, not only on thrown errors. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.09.18-9a7762b Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/rat-tests/log.txt on amdci2
ChrisRackauckas-Claude
force-pushed
the
test/wire-ode-gpu
branch
from
September 26, 2026 12:28
8f2d773 to
a1192ab
Compare
ChrisRackauckas
marked this pull request as ready for review
September 26, 2026 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/GPU/ode_gpu.jlwas added in 2022 (ArrayPartition CuArray / SecondOrderODEProblem discourse fix) but was neverincluded from any test group — git history shows no deliberate disable, only that it was never wired. This adds it to the GPU group body and addsOrdinaryDiffEq(andLinearAlgebra) with compat totest/GPU/Project.tomlso the file can resolve.Verification
This machine has no GPU, so the ODE GPU tests themselves were not executed. Validated only:
julia -e 'Meta.parseall(read("test/GPU/ode_gpu.jl", String))'→ OKObserved status tail:
Runtime correctness of
ode_gpu.jlis validated only by the self-hosted GPU CI job (test_groups.tomlGPU group onself-hosted/gpurunners).Not verified
ode_gpu.jl(no GPU on this host).Please ignore this draft until reviewed by @ChrisRackauckas.
Risk assessment
test/runtests.jlGPU body +test/GPU/Project.tomldeps); no library source changes.Harness: Cursor Agent CLI 2026.09.18-9a7762b; model: auto; transcript: /home/crackauc/sandbox/goals/qa-hygiene/jobs/rat-tests/log.txt on amdci2
Made with Cursor
#662 is fixed by #663 (merged); this PR is its regression test. Rebased onto master to rerun the GPU job.