Skip to content

fill!(::AbstractVectorOfArray, x): fill inner arrays directly, fixing a silent ragged bug #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Oct 10, 2026
Merged

fill!(::AbstractVectorOfArray, x): fill inner arrays directly, fixing a silent ragged bug #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/vector_of_array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,16 +1167,21 @@ end
# fill!
# For DiffEqArray it ignores ts and fills only u
function Base.fill!(VA::AbstractVectorOfArray, x)
for i in 1:length(VA.u)
if VA[:, i] isa Union{AbstractArray, AbstractVectorOfArray}
if ArrayInterface.ismutable(VA.u[i]) || VA.u[i] isa AbstractVectorOfArray
fill!(VA[:, i], x)
for i in eachindex(VA.u)
# Fill the inner array directly instead of through `VA[:, i]`, which
# for a ragged inner array builds and returns a zero-padded *copy* —
# filling that copy does not touch (and silently drops writes to) the
# real storage.
ui = VA.u[i]
if ui isa Union{AbstractArray, AbstractVectorOfArray}
if ArrayInterface.ismutable(ui) || ui isa AbstractVectorOfArray
fill!(ui, x)
else
# For immutable arrays like SVector, create a new filled array
VA.u[i] = fill(x, StaticArraysCore.similar_type(VA.u[i]))
VA.u[i] = fill(x, StaticArraysCore.similar_type(ui))
end
else
VA[:, i] = x
VA.u[i] = x
end
end
return VA
Expand Down
8 changes: 8 additions & 0 deletions test/Core/interface_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,14 @@ testda = DiffEqArray(recursivecopy(testva.u), testts)
fill!(testda, testval)
@test all(x -> (x == testval), testda)

# fill! on a ragged VectorOfArray must fill every inner array, not just the
# longest one. `VA[:, i]` zero-pads a shorter inner array into a throwaway
# copy, so filling through it (instead of through `VA.u[i]` directly) would
# silently drop the write for every inner array shorter than the max.
ragged_fill = VectorOfArray([[1.0, 2.0], [3.0], [4.0, 5.0, 6.0]])
fill!(ragged_fill, 9.0)
@test ragged_fill.u == [[9.0, 9.0], [9.0], [9.0, 9.0, 9.0]]

# copyto!
testva = VectorOfArray(collect(0.1:0.1:1.0))
arr = 0.2:0.2:2.0
Expand Down
Loading