Skip to content

Fix method ambiguity in AbstractVectorOfArray similar() breaking QA on Julia 1.10 #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ChrisRackauckas-Claude wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix method ambiguity in AbstractVectorOfArray similar() breaking QA on Julia 1.10 #678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/vector_of_array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,6 +1162,16 @@ end
) where {T}
return similar(Array{T}, dims)
end
# On Julia versions where Base.similar(::AbstractArray, ::Type, ::Tuple{Integer,
# Vararg{Integer}}) still exists (removed upstream in 1.12), that method and the
# one above are each more specific than the other in one argument position,
# which Aqua reports as an ambiguity. Pin down the Integer-only intersection
# explicitly, mirroring the equivalent pair of methods Base itself defines.
@inline function Base.similar(
VA::AbstractVectorOfArray, ::Type{T}, dims::Tuple{Integer, Vararg{Integer}}
) where {T}
return similar(Array{T}, dims)
end


# fill!
Expand Down
Loading