Repository navigation
Add EPU XML decoding and a cross-source acquisition check - #2
Merged
Merged
Conversation
decode_epu_xml reads voltage, pixel size as recorded, binning, super-resolution factor, fractions, exposure, dose, applied defocus, detector and energy-filter slit from an EPU image XML. It is not registered for automatic dispatch because .xml is too generic an extension to claim. epu_pixel_size_candidates lists the plausible pixel sizes for the saved movie, since EPU records the binned grid. compare_acquisition cross-checks voltage, pixel size, dose, frame count, Cs and magnification across any number of sources (collection sheet, EPU, movie header, RELION or CryoSPARC optics, a deposit) and reports disagreements with a severity. With target_resolution_a it also flags a pixel size whose Nyquist limit cannot reach the target. Motivation: a processing run used 300 kV for data recorded at 200 kV and stalled well short of the published resolution without raising any error. Tests use a synthetic EPU document so no collection data enters this public repo.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
decode_epu_xmlandcompare_acquisition.decode_epu_xmlreads the acquisition settings from an EPU image XML: voltage, pixel size as recorded, binning, super-resolution factor, fractions, exposure, dose, applied defocus, detector and energy-filter slit. It is not auto-dispatched, since.xmlis too generic an extension to claim.epu_pixel_size_candidateslists the plausible pixel sizes for the saved movie, because EPU records the pixel size of the binned grid.compare_acquisitiontakes values from any number of sources (collection sheet, EPU, movie header, RELION or CryoSPARC optics, a deposit) and reports disagreements in voltage, pixel size, dose, frame count, Cs and magnification, worst first. Withtarget_resolution_ait also flags a pixel size whose Nyquist limit cannot reach the target. It does not decide which source is right.Why: a processing run used 300 kV for data recorded at 200 kV. Nothing failed; the map just stalled several angstrom short of the published one. The check makes that kind of disagreement visible before compute is spent.
Checked against:
No version bump and no tag, so nothing publishes on merge. The change sits under Unreleased in the changelog.