Repository navigation
Publish complete storage migrations without losing legacy data - #2
Merged
Merged
Conversation
SeanShaffer88
marked this pull request as ready for review
November 7, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partial first-run copy could make a later launch choose incomplete portable data and hide legacy history. Migration now copies and flushes the complete known-file set into exclusively owned staging, then publishes without replacing a racing destination. Existing portable data and foreign entries remain authoritative or untouched; failures retain legacy data and report recoverable staging.
The private Windows adapter creates and retains staging/child handles, publishes the same owned directory object, and cleans only objects whose ownership remains proven. Failed publication after child handles close retains staging instead of reopening paths or recursively deleting uncertain content. Legacy paths, overrides and calculator behavior remain compatible.
Validation: 175 tests were covered across worker and parent contexts. The sandbox-denied library and v090 groups passed in the parent context (13 and 16 tests); formatting, strict Clippy, release build and native ownership/collision fixtures passed. Independent review passed source/artifact hashes, retained-handle publication and cleanup. Hosted CI pending. A pre-existing unnecessary unsafe block was removed to satisfy strict Clippy.
Limits: Windows x64 with trusted stable ancestors; malicious same-token reparse rewriting, GUI, other platforms, power-loss durability and installer lifecycle remain unverified. Historical unmarked partial portable folders cannot be distinguished automatically from legitimate portable data; recovery guidance is documented. Existing missing-windres icon warning remains.