Repository navigation
ci: annotate ruff findings on the PR and name the steps - #31
Merged
Merged
Conversation
- ruff --output-format=github turns each finding into a line annotation - Name the install, lint and test steps; pytest -ra adds a short failure summary - AGENTS.md: run every CI step, ruff included, before handing over Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> cd tmp/ci-branch
Merged
SeanathanVT
added a commit
that referenced
this pull request
Oct 30, 2026
- ruff --output-format=github turns each finding into a line annotation - Name the install, lint and test steps; pytest -ra adds a short failure summary - AGENTS.md: run every CI step, ruff included, before handing over cd tmp/ci-branch Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#30 failed GitHub CI, and the PR's Checks tab showed only "Process completed with exit code 1". The actual ruff findings were only in the job log, which needs a GitHub login to read. This PR puts lint failures where they're seen and names each step, so it's obvious which one failed.
Changes
ruff check . --output-format=github. Each finding becomes an error annotation on its line in the PR's Files changed tab and in the check summary, with the rule, the message and the suggested fix. Example:FURB167 Use of regular expression alias re.S — help: Replace with re.DOTALL. Ruff still exits 1, so the job still fails.run:steps.-ra, which ends the run with a one-line reason for each failure, error or skip.ruff check .included, not just the tests. The lint failure in Ledger interface redesign (ROADMAP 3.21) #30 got through because only pytest was run locally.GitLab CI is unchanged. Its job log already prints ruff's full output, and merge requests show that log directly.
Verification
ruff check --output-format=githubwith the pinned ruff 0.16.10 prints::errorannotations with file, line, column and the fix hint, and exits 1.🤖 Generated with Claude Code