Repository navigation
Ledger accessibility follow-ups (ROADMAP 3.24) - #32
Merged
Merged
Conversation
- Theme menu: presentational group labels and aria-haspopup="menu" on its button - Selected preset stop is aria-current, not aria-pressed - Focus moves to a neighbouring Delete (or Edit) after deleting a history row - Add profile renders open so it works without JavaScript; script folds it on load Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
SeanathanVT
added a commit
that referenced
this pull request
Oct 30, 2026
- Theme menu: presentational group labels and aria-haspopup="menu" on its button - Selected preset stop is aria-current, not aria-pressed - Focus moves to a neighbouring Delete (or Edit) after deleting a history row - Add profile renders open so it works without JavaScript; script folds it on load Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the four small accessibility gaps that #30's final review deferred as minor, so the 2.0.0 release ships without them. Delivers ROADMAP 3.24.
Changes
role="presentation". Arole="menu"may contain only groups and menu items, so the plain<p>labels were invalid. Each group keeps itsaria-labelledby.aria-haspopup="menu", so screen readers announce that it opens a menu.aria-current="true"instead ofaria-pressed. Screen readers had announced a toggle, but pressing a selected stop doesn't unselect it. The CSS and VT's dark-mode ring follow the new attribute.[Unreleased]entry and need no separate CHANGELOG line.Tests
test_selected_preset_is_current_not_pressedtest_theme_menu_button_announces_a_menutest_add_profile_reachable_without_jstest_add_profile_form_open_after_create_error, and the VT ring check intest_theme_contrast.py.tmp/folder. All passed, with no JS errors:ruff check .is clean.Manual check (Safari on macOS)
🤖 Generated with Claude Code