Repository navigation
fix(ble): space speed commands and step from the target during a ramp (ROADMAP 1.8) - #37
Draft
SeanathanVT wants to merge 1 commit into
Draft
SeanathanVT wants to merge 1 commit into
SeanathanVT wants to merge 1 commit into
Conversation
… (ROADMAP 1.8) - Speed changes are sent at least 1.0 s apart; a newer press replaces one still waiting - +/- step from the status packet's app_speed while the belt ramps toward it - Resume's quick-restart check ignores a speed that is falling - Log status byte 16 (controller_button) changes to investigate the physical remote Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three of the four problems in ROADMAP 1.8 and adds logging to look into the fourth (app commands ignored after a physical remote press).
_SPEED_COMMAND_SPACING_SECONDS); a newer press replaces one still waiting, so rapid presses collapse into the latest.+/-step from the status packet'sapp_speed(the target set by the app, km/h × 10 on a C2) while the belt ramps toward it, and from the reported speed otherwise. That covers changes made with the remote, which leaveapp_speedstale.controller_button) are logged at INFO.Test plan
ruff check .clean+twice quickly, the speed rises two steps-mid-ramp, lands one step below Maxcontroller_buttonchange🤖 Generated with Claude Code