Repository navigation
Fix PostgresModelDataMigrator leaving the swapped-in table without privileges, stats and autovacuum - #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgresModelDataMigratorranVACUUM ANALYZEand the autovacuum reset outside a transaction, whereSET LOCAL search_pathdoes nothing, so both hit the original table. The swapped-in table was left withautovacuum_enabled=falseand no statistics.postgres_prepend_local_search_pathnow raises outside a transaction, likepostgres_set_localalready does.The swapped-in table also lost all its privileges, because the default privileges of a schema don't apply to a table created in another schema. They are now copied right before the swap. Column privileges, and sequence privileges on Django 4.0 and older, are not copied.