add b300 vllm agentX single-node minimaxm3 fp4 EAGLE-GQA MTP#2328
add b300 vllm agentX single-node minimaxm3 fp4 EAGLE-GQA MTP#2328hshrivastava-droid wants to merge 3 commits into
Conversation
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献！请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md，然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人，你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板，包括保留英文语句 如需进行 PR 验证，请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动（flake），重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
2 similar comments
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献！请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md，然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人，你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板，包括保留英文语句 如需进行 PR 验证，请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动（flake），重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献！请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md，然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人，你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板，包括保留英文语句 如需进行 PR 验证，请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动（flake），重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| @@ -0,0 +1,98 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
🟡 PR title 'add b300 vllm agentX single-node minimaxm3 fp4 EAGLE-GQA MTP' is English-only, but AGENTS.md mandates PR titles use the bilingual format <English title> / <中文标题>. Please update the title (and thus the eventual squash-merge commit subject) to append a Simplified Chinese translation.
Extended reasoning...
AGENTS.md line 7 states as a hard requirement: 'PR and GitHub-issue titles & descriptions must be bilingual — include a Simplified Chinese version in addition to English. Title format: <English title> / <中文标题>. ... This applies to every PR and every issue.' The current title of this PR, 'add b300 vllm agentX single-node minimaxm3 fp4 EAGLE-GQA MTP', contains no / <中文标题> segment at all — it is pure English.
This is not a subjective style nitpick; it is an explicit, repo-documented convention that this specific PR fails to satisfy. Because GitHub squash-merges typically default the final commit subject to the PR title, the violation would also propagate into the git history as an English-only commit subject, which separately runs afoul of the bilingual git commit-message convention described in AGENTS.md's Code Conventions section (a prior commit in this repo's history, 48759cd, shows the same pattern of an English-only subject slipping through).
Step-by-step proof:
- AGENTS.md:7 defines the required format:
<English title> / <中文标题>. - The PR's actual title is:
add b300 vllm agentX single-node minimaxm3 fp4 EAGLE-GQA MTP. - Splitting on
/yields only one segment — there is no second, Chinese-language segment. - Therefore the title does not conform to the mandated format.
- Absent a manual edit to the commit subject at merge time, GitHub's squash-merge UI pre-fills the commit message with the PR title, so the same English-only text would become the commit subject, also missing the bilingual requirement called out for commit messages.
No CI check in this repository currently enforces the bilingual title requirement (the only related automation, the CODEOWNER signoff bot, checks for a specific English sign-off phrase, not language coverage of the title), so nothing will fail to merge or run incorrectly as a result — this is purely a documentation/process convention violation, not a functional defect. Fixing it is trivial: the author (or a maintainer) can simply rename the PR to append / <中文标题> with an appropriate Simplified Chinese translation before or at merge time, no code changes are required.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30120171478 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30121331788 |
1 participant
No description provided.