Repository navigation
feat(provision): add the log_scale_on_start column - #15
Merged
Merged
Conversation
SemiPlot draws a pen on a log10 Y axis when the operator asks for one (Semiteq/SemiPlot#72). The axis type a pen opens with is a start value stored beside the pen's other settings, so it lives in semiplot_tags. Add log_scale_on_start boolean NOT NULL DEFAULT false after the start scale pair and put it in plotEditableTagColumns, so the semiplot column grant and the tail check's write probe cover it. The registrar needs no change: a registered pen takes the default and opens on a linear axis. No CHECK ties the flag to a positive minimum; SemiPlot's editor refuses that combination. The CI register step now also probes the table as semiplot: a paired scale is accepted, a half-set or inverted pair fails the scale-pair CHECK, and a NULL flag fails NOT NULL. The grant and probe tests build their expected text from plotEditableTagColumns, so a new column touches the SQL, that list and TestSemiplotTagsColumns. The docs state what a start value is, that "Restore initial scale" returns to the scale pair and the log flag only, that the schema version rule starts with the first installation, and that a database provisioned before then is recreated rather than provisioned again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SemiPlot draws a pen on a log10 Y axis when the operator asks for one (Semiteq/SemiPlot#72). The
axis type a pen opens with is a start value stored beside the pen's other settings, so it needs a
semiplot_tagscolumn thesemiplotrole may update.Change
log_scale_on_start boolean NOT NULL DEFAULT false, declared after the start scale pair andadded to
plotEditableTagColumns: the column grant and the tail check's write probe cover it.The registrar is unchanged; a registered pen opens on a linear axis.
Register pens and probe the semiplot_tags constraints, also runs assemiploton pen 0: a paired scale is accepted,(5, NULL)and(5, 1)fail with 23514, aNULLflag fails with 23502.plotEditableTagColumns;TestSemiplotTagsColumnskeeps the column contract spelled out.semiplot_tagsrow says what a start value is and that "Restore initial scale"returns to the scale pair and the log flag only; "nine" settings columns; the version rule
starts with the first installation, and a database provisioned before then is recreated;
docs/deployment.mdnames the flag. The plan moves todocs/plans/completed/.Verification
go test -count=1 ./...,go vet ./...,golangci-lint run: pass, 0 issues.schema and fails on each of four mutated schemas (
NOT NULLdropped, pairing dropped, orderdropped, a self-comparing CHECK). The
linuxjob on this pull request is the gate.Per-task commits before collapse