Repository navigation
refactor(pens): suffix the start scale pair _on_start - #112
Merged
Merged
Conversation
SemiBase v0.5.0 renamed semiplot_tags.scale_min/scale_max to scale_min_on_start/scale_max_on_start: a column holding what a pen opens with carries the _on_start suffix, as enabled_on_start does. The catalogue reads, the editor's update and the bench seeder name the new columns, so the viewer reads a v0.5.0 database again. The C# members named for the stored pair follow the column: Pen, StoredPen and SyntheticPen expose ScaleMinOnStart/ScaleMaxOnStart, PenSettingChange.Scale and PenField.Scale become ScaleOnStart, and the pen editor's columns, drafts and resource keys take the same suffix. The operator text does not change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SemiBase v0.5.0 (Semiteq/SemiBase#14) renamed
semiplot_tags.scale_min/scale_maxtoscale_min_on_start/scale_max_on_start, so every start value carries the_on_startsuffix.masterstill reads the old names: against the currentghcr.io/semiteq/semibase:latestits catalogueread fails with 42703 and the container tests are red.
Change
Pen,StoredPen,SyntheticPen,PenCatalogColumn,PenColumn, the form drafts;PenSettingChange.ScaleOnStart,PenField.ScaleOnStart,UpdatePenScaleOnStart), and the resource keys follow. Operator text isunchanged.
docs/architectureuse the new names.Prepares #72; the log10 axis follows in its own pull request.
Verification
dotnet build SemiPlot.slnx: 0 errors;dotnet format --verify-no-changes: clean.SemiPlot.Tests.Unit: 1668/1668.git grep -nwE "scale_min|scale_max|ScaleMin|ScaleMax" -- ':!docs/plans'prints nothing.linuxjob against SemiBase v0.5.0.