Skip to content

Generate and ship FFI metadata with ASTrein - #21

Merged
Katze719 merged 8 commits into
mainfrom
feat/ship-ffi-api-metadata
Aug 26, 2026
Merged

Generate and ship FFI metadata with ASTrein#21
Katze719 merged 8 commits into
mainfrom
feat/ship-ffi-api-metadata

Conversation

@Katze719

@Katze719 Katze719 commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • update cpp-core to v2.0.1 and move FFI metadata generation into this repository
  • download the self-contained ASTrein v1.0.0 Linux binary in CI instead of installing a separate Clang toolchain
  • add an opt-in cpp_bindings_linux_ffi_json CMake target that invokes ASTrein directly
  • upload the generated astrein_ffi_api document with the shared library and include it in the JSR package
  • tolerate the initial release-asset build window when downloading ASTrein

@Katze719
Katze719 requested a review from Mqxx August 23, 2026 20:20
@Katze719 @Mqxx
Update .github/workflows/build_binary.yml
2272fc6 
Co-authored-by: Mqx <62719703+Mqxx@users.noreply.github.com>
@Katze719
Katze719 requested a review from Mqxx August 24, 2026 06:15
Mqxx
Mqxx requested changes Aug 24, 2026
View reviewed changes

@Mqxx Mqxx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either we put everything into /bin/ or /ffi/, either way I would like to put the files next to each other.

Comment thread .github/workflows/publish_jsr.yml Outdated
Comment thread .github/workflows/publish_jsr.yml Outdated
Comment thread jsr/.gitignore Outdated
Comment thread jsr/jsr.json Outdated
Comment thread jsr/jsr.json Outdated
Comment thread jsr/README.md Outdated
@Mqxx

Mqxx commented Aug 24, 2026

Copy link
Copy Markdown
Member

I would also like to know, how the AST looks like and if we can tweak/trim it if necessary.

@Katze719

Katze719 commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

cpp_core_ffi_api.json

Katze719 and others added 2 commits August 24, 2026 08:32
@Katze719 @Mqxx
Apply suggestions from code review
ec321fc 
Co-authored-by: Mqx <62719703+Mqxx@users.noreply.github.com>
@Katze719
ci: generate FFI metadata with ASTrein
8e7de2b
@Katze719 Katze719 changed the title Ship cpp-core FFI metadata in JSR package Generate and ship FFI metadata with ASTrein Aug 24, 2026
@Katze719

Katze719 commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

new ffi.json:
cpp_core_ffi_api.json

Mqxx
Mqxx requested changes Aug 25, 2026
View reviewed changes
Comment thread .github/workflows/build_binary.yml Outdated
Comment thread .github/workflows/publish_jsr.yml Outdated
Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
Comment thread jsr/jsr.json Outdated
Comment thread jsr/jsr.json Outdated
@Katze719 @Mqxx
Apply suggestions from code review
b61794e 
Co-authored-by: Mqx <62719703+Mqxx@users.noreply.github.com>
@Katze719
Katze719 requested a review from Mqxx August 25, 2026 18:28
Mqxx
Mqxx requested changes Aug 26, 2026
View reviewed changes
Comment thread .github/workflows/build_binary.yml Outdated
Comment thread .github/workflows/build_binary.yml Outdated
Comment thread .github/workflows/publish_jsr.yml Outdated
Comment thread jsr/README.md Outdated
Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
@Katze719 @Mqxx
Apply suggestions from code review
3c1ece5 
Co-authored-by: Mqx <62719703+Mqxx@users.noreply.github.com>
@Katze719
Katze719 merged commit 28e70ec into main Aug 26, 2026
7 checks passed
@Katze719
Katze719 deleted the feat/ship-ffi-api-metadata branch August 26, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mqxx Mqxx Mqxx requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Katze719 @Mqxx