Repository navigation
Fix thirtyfour deadlocks causing slow test execution - #108
Merged
Merged
Conversation
thirtyfour 0.37 changed SessionHandle::Drop to join a cleanup thread, which blocks the #[tokio::test] current-thread runtime that drives the reqwest client IO. DELETE /session then never reaches chromedriver, and teardown only unblocks when request_timeout expires, so every driver test cost 120s. Quitting inside the test runs teardown while the runtime is still live, and lets Drop return early via its initialized check. The explicit request_timeout bounds the remaining case where an assertion fails before the quit. Integration test suite goes from 481s back to 1.9s. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vivax3794
enabled auto-merge (rebase)
October 8, 2026 13:15
vivax3794
disabled auto-merge
October 8, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also addeds the
jobsargument to the justfile.