quick wins security dead code - #5
Merged
Merged
Conversation
ShanedixonGit
commented
Sep 26, 2026
ShanedixonGit
commented
Owner
- Refuse to write a report through a symlink, so a shared folder cannot redirect it
- Stop leaving the GitHub token in CI checkouts, since no job pushes
- Remove functions, constants and a parameter that nothing used
… redirect it A symlink planted at audit_*.json, audit_*.html or remediation.md was followed, sending the report to wherever it pointed. Reports are now opened with O_NOFOLLOW and set to 0600 on the open descriptor before anything is written.
search_roots, THERMAL_KEYS, _yes_no and _simple's privileged_hint had no callers, and shell.run had an except branch identical to the catch-all below it. Audit output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.