Key schema definition traits by schema type - #138
Open
adampetro wants to merge 2 commits into
Open
Conversation
Assisted-By: devx/d679ffab-df3b-41b6-b9d9-d39223d17670
Assisted-By: devx/d679ffab-df3b-41b6-b9d9-d39223d17670
adampetro
marked this pull request as ready for review
August 26, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SchemaDefinitionassociation to each schema-owned definition trait.Why
The previous API repeated structural equality bounds across the definition traits. The new API makes
SchemaDefinitionthe owner of the complete definition type family. This reduces generic bounds and prevents references from different schema families from being mixed.The core input and output references now depend only on the schema definition. Validator-specific variable types no longer add representation parameters to the public core API.
Compatibility
This change updates public traits and reference types. It is a source-breaking change and needs a minor version release.
Validation
cargo check --workspace --all-featurescargo test --workspace --all-featurescargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --check