Skip to content

[Swift][Demo]: Add a checkout presentation picker - #775

Open
kieran-osgood-shopify wants to merge 1 commit into
mainfrom
ko/swift-sample-checkout-presentation
Open

kieran-osgood-shopify wants to merge 1 commit into
mainfrom
ko/swift-sample-checkout-presentation

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

What changes are you making?

This is a pre-emptive change to support testing of #649.

Add a persisted Checkout presentation picker under Settings → Features in the Swift demo.

The picker changes the mechanism we use to present checkout

SwiftUI (default) UIKit
Existing ShopifyCheckout sheet Direct CheckoutViewController construction and UIKit presentation
Closed Open
1-settings-swiftui-default 2-picker-menu-open

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

SDK README changes are not required for this sample-only setting.

@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Sep 14, 2026
@kieran-osgood-shopify
kieran-osgood-shopify added this pull request to stack #776 September 14, 2026 14:46
Assisted-By: devx/e9549c39-4038-46fb-b955-39538bc9441f
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the ko/swift-sample-checkout-presentation branch from 8dba856 to e503219 Compare October 6, 2026 14:32
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Bundle Size Budgets

Budget Size Limits Result
— — — ➖ No configured budgets affected

Bundle and package size

Web bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.

Platform Measurement Compression Base Head Delta
- - - - - -
How sizes are measured

Measured from the PR base SHA and PR head SHA. Web bundle rows sum shipped .js, .mjs, and .cjs files under dist/, excluding source maps and declarations. The gzip bundle size sums files compressed individually with gzip -n -9. npm package sizes are gzip-compressed .tgz archives; Android AAR sizes are ZIP archives. Package sizes are not final app binary sizes.

@kieran-osgood-shopify kieran-osgood-shopify changed the title [Swift][Sample]: Add a checkout presentation picker [Swift][Demo]: Add a checkout presentation picker Oct 7, 2026
@kieran-osgood-shopify
kieran-osgood-shopify marked this pull request as ready for review October 7, 2026 10:55
@kieran-osgood-shopify
kieran-osgood-shopify requested a review from a team as a code owner October 7, 2026 10:55

@markmur markmur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✨

@bitrise

bitrise Bot commented Oct 7, 2026

Copy link
Copy Markdown

Bitrise builds

E2E · iOS CI

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
Swift Install with Tophat

Checkout Kit E2E results

Status Tags Target Platform OS version tag Device
❌ launch, checkout-presentation, checkout-completion, buyer-identity, preload swift ios latest iPhone 15
iOS 27 Beta

Failures

Caution

If you believe an assertion is flaky, please raise a ticket in the #checkout-kit-devs channel so it can be addressed.

BrowserStack artifacts require BrowserStack access. Sign in to BrowserStack App Automate before opening artifact links.

iOS — swift

Test Status Artifacts
./tests/shared/checkout-hardcoded-buyer-identity ❌ BrowserStack
./tests/shared/checkout-present-and-close ❌ BrowserStack
./tests/shared/native-preload-ready ❌ BrowserStack
./tests/shared/launch-smoke ❌ BrowserStack
./tests/shared/checkout-guest ❌ BrowserStack

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants